Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Laravel 11 support #364

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Add Laravel 11 support #364

merged 2 commits into from
Mar 12, 2024

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Mar 3, 2024 •
edited
Loading

This is another PR to add Laravel 11 support.

I've fixed:

  • GitHub Actions:
    • don't trigger push event for Pull Requests.
    • you just need to set 1 illuminate package version, and thanks to orchestra/testbench dependencies, the proper laravel/framework version is used.
  • Acceptance tests:
    • fixes regarding of recent psalm changes
  • Application tests:
    • updated the baselines

@asbiin asbiin changed the title Add laravel 11 support Add Laravel 11 support Mar 3, 2024
@ABartelt
Copy link

ABartelt commented Mar 5, 2024

Nice!

@asbiin
Copy link
Contributor Author

asbiin commented Mar 12, 2024

@alies-dev Hi! Laravel 11 is out now, could you review this one please?

alies-dev
alies-dev approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@alies-dev alies-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asbiin AWESOME!!! Thank a lot! The CI is green again - special thanks for this! 💪

@alies-dev alies-dev merged commit 87f3cf1 into psalm:master Mar 12, 2024
18 checks passed
@alies-dev alies-dev mentioned this pull request Mar 12, 2024
Closed
@asbiin asbiin deleted the laravel11 branch March 13, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alies-dev alies-dev alies-dev approved these changes

Assignees

@asbiin asbiin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asbiin @ABartelt @alies-dev